Fix Dependencies of RCTFabric for RCTInterpolateColorInRange#48753
Closed
cipolleschi wants to merge 2 commits into
Closed
Fix Dependencies of RCTFabric for RCTInterpolateColorInRange#48753cipolleschi wants to merge 2 commits into
cipolleschi wants to merge 2 commits into
Conversation
Summary: The React-FabricComponent was importing some non-existent files when we build for iOS with cocoapods. This change fixes it. ## Changelog [Internal] - Only include ReactCommon and ios platform for TextInput Differential Revision: D68319960
Summary: [This commit](facebook@cc89ddd) introduced a dependency between RCTFabric and RCTAnimation because RCTFabric is now using `RCTInterpolateColorInRange` which is defined in `RCTAnimation`. To unblock the CI, I'm adding the dependency to the RCTFabric.podspec However, I'm not convinced that this is the proper fix. We should move the function to a common dependency between RCTFabric and RCTAnimation. Probably in `RCTUtils`. ## Changelog: [Internal] - Fix CI by making RCTFabric depend on RCTAnimation Differential Revision: D68322935
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68322935 |
Contributor
|
This pull request has been merged in a7aed70. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This commit introduced a dependency between RCTFabric and RCTAnimation because RCTFabric is now using
RCTInterpolateColorInRangewhich is defined inRCTAnimation.To unblock the CI, I'm adding the dependency to the RCTFabric.podspec
However, I'm not convinced that this is the proper fix. We should move the function to a common dependency between RCTFabric and RCTAnimation. Probably in
RCTUtils.Changelog:
[Internal] - Fix CI by making RCTFabric depend on RCTAnimation
Differential Revision: D68322935