Add feature flag to enable running JS GC on memory pressure with Bridgeless#48771
Closed
lyahdav wants to merge 1 commit into
Closed
Add feature flag to enable running JS GC on memory pressure with Bridgeless#48771lyahdav wants to merge 1 commit into
lyahdav wants to merge 1 commit into
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68290689 |
lyahdav
force-pushed
the
export-D68290689
branch
from
7575bc1 to
ab5e48d
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68290689 |
lyahdav
force-pushed
the
export-D68290689
branch
from
ab5e48d to
7ca646d
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68290689 |
…geless (facebook#48771) Summary: Pre Bridgeless RN iOS apps relied on [RCTCxxBridge](https://www.internalfb.com/code/fbsource/[44b3ff81a2875d66675774f2c71643622ea03c36]/xplat/js/react-native-github/packages/react-native/React/CxxBridge/RCTCxxBridge.mm?lines=376) to tell Hermes to GC when the OS detects memory pressure. With bridgeless we don't use RCTCxxBridge so we don't get that behavior anymore. This adds a feature flag to experiment with getting the same behavior with Bridgeless. Changelog: [iOS] [Added] - Add feature flag to enable running JS GC on iOS memory pressure with Bridgeless Reviewed By: yungsters Differential Revision: D68290689
lyahdav
force-pushed
the
export-D68290689
branch
from
7ca646d to
5e4cb70
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68290689 |
Contributor
|
This pull request has been merged in 6cbdc94. |
Collaborator
|
This pull request was successfully merged by @lyahdav in 6cbdc94 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Pre Bridgeless RN iOS apps relied on RCTCxxBridge to tell Hermes to GC when the OS detects memory pressure. With bridgeless we don't use RCTCxxBridge so we don't get that behavior anymore. This adds a feature flag to experiment with getting the same behavior with Bridgeless.
Differential Revision: D68290689