Fix data race in TraceSection.h#48774
Closed
christophpurrer wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68366837 |
Summary: [Changelog] [Internal] - Fix data race in TraceSection.h ## Issue The `instrumentsLogHandle` variable is a static variable that is initialized lazily when the `getOrCreateInstrumentsLogHandle()` function is called. However, this initialization is not thread-safe. Multiple threads may call this function simultaneously, leading to a data race on the `instrumentsLogHandle` variable. Differential Revision: D68366837
christophpurrer
force-pushed
the
export-D68366837
branch
from
9efc848 to
c8ba150
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68366837 |
Contributor
|
This pull request has been merged in d154cd5. |
Collaborator
|
This pull request was successfully merged by @christophpurrer in d154cd5 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
[Changelog] [Internal] - Fix data race in TraceSection.h
Issue
The
instrumentsLogHandlevariable is a static variable that is initialized lazily when thegetOrCreateInstrumentsLogHandle()function is called. However, this initialization is not thread-safe. Multiple threads may call this function simultaneously, leading to a data race on theinstrumentsLogHandlevariable.Differential Revision: D68366837