Run the enableAccumulatedUpdatesInRawPropsAndroid QE for View only#48852
Run the enableAccumulatedUpdatesInRawPropsAndroid QE for View only#48852dmytrorykun wants to merge 2 commits intofacebook:mainfrom
Conversation
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68492332 |
|
This pull request was exported from Phabricator. Differential Revision: D68492332 |
dmytrorykun
force-pushed
the
export-D68492332
branch
from
c11fe68 to
17eb0cd
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68492332 |
dmytrorykun
force-pushed
the
export-D68492332
branch
from
17eb0cd to
6a25fbe
Compare
dmytrorykun
force-pushed
the
export-D68492332
branch
from
6a25fbe to
9bf7f33
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68492332 |
…acebook#48939) Summary: The `enableAccumulatedUpdatesInRawPropsAndroid` experiment needs additional context for finer setup. Specifically it needs to be conditionally enabled based on a component name. This information is not accessible form the `Props` constructor. This diff moves the experimental logic to `ConcreteComponentDescriptor`. Changelog: [Internal] Differential Revision: D68633985
…acebook#48852) Summary: The `enableAccumulatedUpdatesInRawPropsAndroid` param will be tested together with the `enablePropsUpdateReconciliationAndroid` param. `enablePropsUpdateReconciliationAndroid` currently only supports `View` components. This diff changes `enableAccumulatedUpdatesInRawPropsAndroid` to also run only for `View`s. Differential Revision: D68492332
dmytrorykun
force-pushed
the
export-D68492332
branch
from
9bf7f33 to
d194c5e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68492332 |
|
Hi @dmytrorykun! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Closed internally |
3 participants
Summary:
The
enableAccumulatedUpdatesInRawPropsAndroidparam will be tested together with theenablePropsUpdateReconciliationAndroidparam.enablePropsUpdateReconciliationAndroidcurrently only supportsViewcomponents.This diff changes
enableAccumulatedUpdatesInRawPropsAndroidto also run only forViews.Differential Revision: D68492332