Move methods to access internals of DOM nodes to a separate module#48854
Closed
rubennorte wants to merge 1 commit into
Closed
Move methods to access internals of DOM nodes to a separate module#48854rubennorte wants to merge 1 commit into
rubennorte wants to merge 1 commit into
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67654404 |
rubennorte
force-pushed
the
export-D67654404
branch
from
083926b to
5e6436e
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67654404 |
rubennorte
force-pushed
the
export-D67654404
branch
from
5e6436e to
0089acb
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67654404 |
rubennorte
force-pushed
the
export-D67654404
branch
from
0089acb to
965d591
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67654404 |
…acebook#48854) Summary: Pull Request resolved: facebook#48854 Changelog: [internal] Moves the internals to access instance handle and shadow node from public instances from `ReadOnlyNode` to `NodeInternals` so it's more obvious when people are reaching into internal APIs/state. Differential Revision: D67654404
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67654404 |
rubennorte
force-pushed
the
export-D67654404
branch
from
965d591 to
7b56cc0
Compare
Contributor
|
This pull request has been merged in 348b917. |
Collaborator
|
This pull request was successfully merged by @rubennorte in 348b917 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
Moves the internals to access instance handle and shadow node from public instances from
ReadOnlyNodetoNodeInternalsso it's more obvious when people are reaching into internal APIs/state.Differential Revision: D67654404