Modify public API script to make it opt-in in src/private, instead of opt-out#48866
Closed
rubennorte wants to merge 2 commits into
Closed
Modify public API script to make it opt-in in src/private, instead of opt-out#48866rubennorte wants to merge 2 commits into
rubennorte wants to merge 2 commits into
Conversation
Differential Revision: D68496270
… opt-out Summary: Changelog: [internal] The current test to create a snapshot of the public API was recently modified to include `src/private` but excluding certain directories from it. This replaces the opt-out with an opt-in mechanism, where we only use it where necessary (new DOM APIs, etc.). Reviewed By: huntie Differential Revision: D68496269
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68496269 |
Contributor
|
This pull request has been merged in 04f9451. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
The current test to create a snapshot of the public API was recently modified to include
src/privatebut excluding certain directories from it.This replaces the opt-out with an opt-in mechanism, where we only use it where necessary (new DOM APIs, etc.).
Reviewed By: huntie
Differential Revision: D68496269