Back out "Disable weak event emitter in AttributedString for Apple Silicon Mac running iOS build app"#48868
Closed
javache wants to merge 1 commit into
Closed
Back out "Disable weak event emitter in AttributedString for Apple Silicon Mac running iOS build app"#48868javache wants to merge 1 commit into
javache wants to merge 1 commit into
Conversation
…licon Mac running iOS build app" Summary: Original commit changeset: ac48be3305eb Original Phabricator Diff: D68093083 Changelog: [iOS][Removed] - Removed workaround for a iOS build app running on Apple Silicon Mac(in Xcode Destination: "Mac(Designed for iPad)") TextInput crash due to serialization attempt of WeakEventEmitter Reviewed By: javache Differential Revision: D68452788
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68452788 |
Contributor
|
This pull request has been merged in 9b06d0d. |
Collaborator
|
This pull request was successfully merged by @leejinsquidman in 9b06d0d When will my fix make it into a release? | How to file a pick request? |
|
@javache Do you maybe have some more context on why this was reverted and if there might be a better fix in the works? |
Member
Author
This caused some internal issues were onPress was no longer working for nested Text on iOS |
|
Thanks for clarifying. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Original commit changeset: ac48be3305eb
Original Phabricator Diff: D68093083
Changelog: [iOS][Removed] - Removed workaround for a iOS build app running on Apple Silicon Mac(in Xcode Destination: "Mac(Designed for iPad)") TextInput crash due to serialization attempt of WeakEventEmitter
Reviewed By: javache
Differential Revision: D68452788