Migrated Libraries/WebSocket/* to export syntax.#48884
Closed
iwoplaza wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68554260 |
Summary: ## Motivation Modernising the react-native codebase to allow for ingestion by modern Flow tooling. ## This diff - Updates files in `Libraries/WebSocket` to use `export` syntax - Appends `.default` to requires of the changed files. - Updates mocks. - Updates the public API snapshot (intented breaking change) Changelog: [General][Breaking] - Files inside `Libraries/WebSocket` use `export` syntax, which requires the addition of `.default` when imported with the CJS `require` syntax. Differential Revision: D68554260
iwoplaza
force-pushed
the
export-D68554260
branch
from
0aa2d08 to
de83f1b
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68554260 |
Contributor
|
This pull request has been merged in 7df73ee. |
Collaborator
|
This pull request was successfully merged by @iwoplaza in 7df73ee When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Motivation
Modernising the react-native codebase to allow for ingestion by modern Flow tooling.
This diff
Libraries/WebSocketto useexportsyntax.defaultto requires of the changed files.Changelog:
[General][Breaking] - Files inside
Libraries/WebSocketuseexportsyntax, which requires the addition of.defaultwhen imported with the CJSrequiresyntax.Differential Revision: D68554260