add tests for ScrollView.onScroll#48891
Closed
sammy-SC wants to merge 2 commits into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68499566 |
…#48801) Summary: changelog: [internal] Adds isUnique option to Fantom.dispatchNativeEvent. isUnique controls whether only the last event of the same type and target is dispatched to JavaScript or all events are queued and dispatched. Reviewed By: rubennorte Differential Revision: D68416157
Summary: changelog: [internal] add two tests covering onScroll: one for the case where onScroll is triggered multiple times during one UI tick and one where it is triggered once per UI tick. Reviewed By: rubennorte Differential Revision: D68499566
sammy-SC
force-pushed
the
export-D68499566
branch
from
156643e to
80a8eec
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68499566 |
Contributor
|
This pull request has been merged in 0353648. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
changelog: [internal]
add two tests covering onScroll: one for the case where onScroll is triggered multiple times during one UI tick and one where it is triggered once per UI tick.
Reviewed By: rubennorte
Differential Revision: D68499566