Remove seemingly unused AnimatedWeb file.#48894
Closed
iwoplaza wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68558237 |
Summary: ## Motivation In our efforts to migrate the RN codebase to modern Flow (to enable ingestion by modern Flow tooling) I stumbled upon the `AnimatedWeb.js` file, which does not seems to be imported anywhere throughout the monorepo. Searching on GitHub for imports to this file in OSS projects returned no results. In case this file has actual uses outside of Meta (e.g. in OSS), I'll abandon the diff 🙌 ## This diff - Removes `Libraries/Animated/AnimatedWeb.js` file Changelog: [General][Breaking] Removed `Libraries/Animated/AnimatedWeb.js` file. Reviewed By: cortinico Differential Revision: D68558237
iwoplaza
force-pushed
the
export-D68558237
branch
from
bc8af92 to
85b0322
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68558237 |
Contributor
|
This pull request has been merged in ecae8a2. |
Collaborator
|
This pull request was successfully merged by @iwoplaza in ecae8a2 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Motivation
In our efforts to migrate the RN codebase to modern Flow (to enable ingestion by modern Flow tooling) I stumbled upon the
AnimatedWeb.jsfile, which does not seems to be imported anywhere.In case this file has actual uses outside of Meta (e.g. in OSS), I'll abandon the diff 🙌
This diff
Libraries/Animated/AnimatedWeb.jsfileChangelog:
[General][Breaking] Removed
Libraries/Animated/AnimatedWeb.jsfile.Differential Revision: D68558237