Stable API - Make AnimatedNodeWithUpdateableConfig internal#48900
Closed
cortinico wants to merge 1 commit into
Closed
Stable API - Make AnimatedNodeWithUpdateableConfig internal#48900cortinico wants to merge 1 commit into
cortinico wants to merge 1 commit into
Conversation
Summary: I've verified that this interface is not used externally, so I'm making it internal. https://github.com/search?type=code&q=NOT+is%3Afork+NOT+org%3Afacebook+NOT+repo%3Areact-native-tvos%2Freact-native-tvos+NOT+repo%3Anuagoz%2Freact-native+NOT+repo%3A2lambda123%2Freact-native+NOT+repo%3Apvinis%2Freact-native---investigation+NOT+repo%3Abeanchips%2Ffacebookreactnative+NOT+repo%3AfabOnReact%2Freact-native-notes+NOT+user%3Ahuntie+NOT+repo%3Amolangning%2Freversing-discord+com.facebook.react.animated.AnimatedNodeWithUpdateableConfig+ Changelog: [Android] [Removed] - Stable API - Make `AnimatedNodeWithUpdateableConfig` internal as it was not used in OSS Differential Revision: D68562055
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68562055 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Jan 23, 2025
…ose warnings Summary: We do have the `jest/no-disabled-tests` rule enabled which is firing warning which we're nota actively looking into. Example: facebook#48900 I'm disabling the rule in the .eslintrc.js file for our tests so it won't emit those warnings anymore. Disabled tests will be catch by TestX internally. Changelog: [Internal] [Changed] - Differential Revision: D68563365
Contributor
|
This pull request has been merged in 54e0b69. |
Collaborator
|
This pull request was successfully merged by @cortinico in 54e0b69 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
I've verified that this interface is not used externally, so I'm making it internal.
https://github.com/search?type=code&q=NOT+is%3Afork+NOT+org%3Afacebook+NOT+repo%3Areact-native-tvos%2Freact-native-tvos+NOT+repo%3Anuagoz%2Freact-native+NOT+repo%3A2lambda123%2Freact-native+NOT+repo%3Apvinis%2Freact-native---investigation+NOT+repo%3Abeanchips%2Ffacebookreactnative+NOT+repo%3AfabOnReact%2Freact-native-notes+NOT+user%3Ahuntie+NOT+repo%3Amolangning%2Freversing-discord+com.facebook.react.animated.AnimatedNodeWithUpdateableConfig+
Changelog:
[Android] [Removed] - Stable API - Make
AnimatedNodeWithUpdateableConfiginternal as it was not used in OSSDifferential Revision: D68562055