Migrate to Inspector trace#48923
Closed
hoxyq wants to merge 2 commits into
Closed
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68439734 |
hoxyq
force-pushed
the
export-D68439734
branch
from
ec7cc9e to
ad4eeee
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68439734 |
…le events (facebook#48906) Summary: # Changelog: [Internal] It looks like on `Chrome` side, Complete events (`ph="X"`) are only used for Renderer-related events. For user-land events with duration (non-instant events), there is a [set of supported types](https://github.com/ChromeDevTools/devtools-frontend/blob/99a9104ae974f8caa63927e356800f6762cdbf25/front_end/models/trace/types/TraceEvents.ts#L62-L65), which don't include `"X"`. Later, pair of such events will form a [performance measure event](https://github.com/ChromeDevTools/devtools-frontend/blob/99a9104ae974f8caa63927e356800f6762cdbf25/front_end/models/trace/types/TraceEvents.ts#L2256-L2258). Differential Revision: D68564754
Summary: # Changelog: [Internal] Starting from this diff, React Native will emit inspector traces, the ones that will have the same UI as if it was recorded in a browser. We are going to fake it by sending "TracingStartedInPage" event. For a corresponding logic on Chrome DevTools Frontend side, see [this](https://github.com/ChromeDevTools/devtools-frontend/blob/192673131cf3e6e0bcdb4a97bd0bd39c75f1b3c2/front_end/models/trace/handlers/MetaHandler.ts#L68-L80) as a starting point. Because of this, custom tracks are now grouped under "Timings" track, although with a better color scheme: - We no longer need the logic for placing tracks under arbitrary thread ids to have them grouped. - The real support for extension tracks (custom tracks for Performance panel) will be added in the next diff. Differential Revision: D68439734
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Jan 24, 2025
Summary: # Changelog: [Internal] Starting from this diff, React Native will emit inspector traces, the ones that will have the same UI as if it was recorded in a browser. We are going to fake it by sending "TracingStartedInPage" event. For a corresponding logic on Chrome DevTools Frontend side, see [this](https://github.com/ChromeDevTools/devtools-frontend/blob/192673131cf3e6e0bcdb4a97bd0bd39c75f1b3c2/front_end/models/trace/handlers/MetaHandler.ts#L68-L80) as a starting point. Because of this, custom tracks are now grouped under "Timings" track, although with a better color scheme: - We no longer need the logic for placing tracks under arbitrary thread ids to have them grouped. - The real support for extension tracks (custom tracks for Performance panel) will be added in the next diff. Differential Revision: D68439734
hoxyq
force-pushed
the
export-D68439734
branch
from
ad4eeee to
b5357e6
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68439734 |
Contributor
|
This pull request has been merged in 2e5fa4e. |
ghost
pushed a commit
to discord/react-native
that referenced
this pull request
Jul 29, 2025
Summary: Pull Request resolved: facebook#48923 # Changelog: [Internal] Starting from this diff, React Native will emit inspector traces, the ones that will have the same UI as if it was recorded in a browser. We are going to fake it by sending "TracingStartedInPage" event. For a corresponding logic on Chrome DevTools Frontend side, see [this](https://github.com/ChromeDevTools/devtools-frontend/blob/192673131cf3e6e0bcdb4a97bd0bd39c75f1b3c2/front_end/models/trace/handlers/MetaHandler.ts#L68-L80) as a starting point. Because of this, custom tracks are now grouped under "Timings" track, although with a better color scheme: - We no longer need the logic for placing tracks under arbitrary thread ids to have them grouped. - The real support for extension tracks (custom tracks for Performance panel) will be added in the next diff. Reviewed By: huntie Differential Revision: D68439734 fbshipit-source-id: 8e5c525a71578375904edc6d473308eb710b5867
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Starting from this diff, React Native will emit inspector traces, the ones that will have the same UI as if it was recorded in a browser.
We are going to fake it by sending "TracingStartedInPage" event. For a corresponding logic on Chrome DevTools Frontend side, see this as a starting point.
Because of this, custom tracks are now grouped under "Timings" track, although with a better color scheme:
Differential Revision: D68439734