Skip to content

Use uint32_t for httpStatus #48946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
christophpurrer wants to merge 1 commit into from
Closed

Use uint32_t for httpStatus #48946

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/react-native/ReactCommon/jsinspector-modern/NetworkIOAgent.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ static constexpr std::array kTextMIMETypePrefixes{
namespace {

struct InitStreamResult {
int httpStatusCode;
uint32_t httpStatusCode;
Headers headers;
std::shared_ptr<Stream> stream;
};
Expand Down Expand Up @@ -113,7 +113,7 @@ class Stream : public NetworkRequestListener,
processPending();
}

void onHeaders(int httpStatusCode, const Headers& headers) override {
void onHeaders(uint32_t httpStatusCode, const Headers& headers) override {
// Find content-type through case-insensitive search of headers.
for (const auto& [name, value] : headers) {
std::string lowerName = name;
Expand Down
4 changes: 2 additions & 2 deletions packages/react-native/ReactCommon/jsinspector-modern/NetworkIOAgent.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ struct ReadStreamParams {
struct NetworkResource {
bool success{};
std::optional<std::string> stream;
std::optional<int> httpStatusCode;
std::optional<uint32_t> httpStatusCode;
std::optional<std::string> netErrorName;
std::optional<Headers> headers;
folly::dynamic toDynamic() const {
Expand Down Expand Up @@ -111,7 +111,7 @@ class NetworkRequestListener {
* \param httpStatusCode The HTTP status code received.
* \param headers Response headers as an unordered_map.
*/
virtual void onHeaders(int httpStatusCode, const Headers& headers) = 0;
virtual void onHeaders(uint32_t httpStatusCode, const Headers& headers) = 0;

/**
* To be called by the delegate on receipt of data chunks.
Expand Down