Update Gemfile#48966
Closed
cipolleschi wants to merge 3 commits into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68706060 |
cipolleschi
force-pushed
the
export-D68706060
branch
from
5e4fd17 to
d82de50
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68706060 |
Summary: We are moving away from Cocoapods toward alternative solution. We are adding this deprecation message to help inform our users that this change is happening. Part of the Cocoapods tasks will be moved to an alternative script that will be invoked by Expo and by the Community CLI. The warning message tells the users what to do as an alternative to `pod install`. ## Changelog: [iOS][Deprecated] - deprecate calling `pod install` directly Reviewed By: cortinico Differential Revision: D68704127
…8961) Summary: One of Cocoapods responsibility is to run Codegen while creating the Xcode workspace. Moving away from Cocoapods, this is a step we need to move to a different place. This change let us to disable running codegen at cocoapods time when we pass the `RCT_SKIP_CODEGEN=1` or when we pass the `RCT_IGNORE_PODS_DEPRECATION=1` flag calling pod install. When calling `pod install` with `RCT_IGNORE_PODS_DEPRECATION` we are either: * using one of the Scripts provided by Expo or by the Community CLI *or* * we are preparing the project using the legacy mode and, therefore, we want to keep running codegen. ## Changelog [iOS][Changed] - Stop running codegen when running pod install Reviewed By: cortinico Differential Revision: D68704604
Summary: In our previous fix for concurrent-ruby, we have been a bit too strict. Version 1.3.4 is a valid and working version. The broken version is 1.3.5. ## Changelog: [iOS][Changed] - Fix Gemfile versions Reviewed By: cortinico Differential Revision: D68706060
cipolleschi
force-pushed
the
export-D68706060
branch
from
d82de50 to
e306c3a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68706060 |
Contributor
|
This pull request has been merged in 2527d29. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
In our previous fix for concurrent-ruby, we have been a bit too strict. Version 1.3.4 is a valid and working version. The broken version is 1.3.5.
Changelog:
[iOS][Changed] - Fix Gemfile versions
Differential Revision: D68706060