Prepare ReactNativePrivateInterface for new React renderer calls to handle root/document nodes#49010
Closed
rubennorte wants to merge 3 commits into
Closed
Prepare ReactNativePrivateInterface for new React renderer calls to handle root/document nodes#49010rubennorte wants to merge 3 commits into
rubennorte wants to merge 3 commits into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68561173 |
rubennorte
force-pushed
the
export-D68561173
branch
from
3e24a28 to
b3e6519
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68561173 |
rubennorte
force-pushed
the
export-D68561173
branch
from
b3e6519 to
5436bc3
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68561173 |
rubennorte
force-pushed
the
export-D68561173
branch
from
5436bc3 to
8d7b17c
Compare
rubennorte
force-pushed
the
export-D68561173
branch
from
8d7b17c to
b83e2cd
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 29, 2025
…calls to handle root/document nodes (facebook#49010) Summary: Changelog: [internal] This adds a stub method for `ReactNativePrivateInterface.createPublicRootInstance`, which just returns `null` for now, so we can synchronize the React renderer that will try to use it to create root instances. Initially, this will not do anything and React will just pass the `null` value around. When we implement the document API, we will return a proper instance and React will pass it to `createPublicInstance` so we can link things at runtime. Reviewed By: javache Differential Revision: D68561173
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68561173 |
Summary: Changelog: [internal] We're modifying some core APIs in the RN render in following diffs, so this adds a simple benchmark as a safety mechanism to verify those don't regress performance significantly. Reviewed By: yungsters Differential Revision: D68772175
…#49009) Summary: Changelog: [internal] Native APIs so far have returned instance handles from React to reference nodes in the rendered UI tree, but now that we're adding support for the document API, this isn't sufficient to represent all types of nodes. Both for the document and for its `documentElement`, we don't have an instance handle from React that links to the node, but we're going to represent that differently. This is a refactor so the existing methods use a mostly opaque `NativeNodeReference` type so we can implement it as a union of React instance handles and the future types we're going to introduce to support document. Reviewed By: javache Differential Revision: D67704855
…andle root/document nodes (facebook#49010) Summary: Changelog: [internal] This adds a stub method for `ReactNativePrivateInterface.createPublicRootInstance`, which just returns `null` for now, so we can synchronize the React renderer that will try to use it to create root instances. Initially, this will not do anything and React will just pass the `null` value around. When we implement the document API, we will return a proper instance and React will pass it to `createPublicInstance` so we can link things at runtime. Reviewed By: javache Differential Revision: D68561173
rubennorte
force-pushed
the
export-D68561173
branch
from
b83e2cd to
cdf1751
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68561173 |
Contributor
|
This pull request has been merged in 8678d15. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
This adds a stub method for
ReactNativePrivateInterface.createPublicRootInstance, which just returnsnullfor now, so we can synchronize the React renderer that will try to use it to create root instances.Initially, this will not do anything and React will just pass the
nullvalue around. When we implement the document API, we will return a proper instance and React will pass it tocreatePublicInstanceso we can link things at runtime.Differential Revision: D68561173