Improve naming for benchmark suite options#49014
Closed
rubennorte wants to merge 1 commit into
Closed
Conversation
Summary: Changelog: [internal] Use better names for the Fantom benchmarking API than the ones defined in `tinybench`: * `time` => `minDuration` * `iterations` = `minIterations` * `warmupTime` => `minWarmupDuration` * `warmupIterations` => `minWarmupIterations` Differential Revision: D68710952
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68710952 |
Collaborator
|
This pull request was successfully merged by @rubennorte in 252294b When will my fix make it into a release? | How to file a pick request? |
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 5, 2025
Summary: Pull Request resolved: #49192 Changelog: [internal] We refactored the public API of Fantom benchmarks in #49014 but that refactor broke test only mode, as we started overriding the options after setting them. This fixes that. Reviewed By: javache Differential Revision: D69176983 fbshipit-source-id: 9afc2d2f27fb2ee0aa452d4b02c28531acf40b8e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
Use better names for the Fantom benchmarking API than the ones defined in
tinybench:time=>minDurationiterations=minIterationswarmupTime=>minWarmupDurationwarmupIterations=>minWarmupIterationsDifferential Revision: D68710952