Print nativeID in debug props for Props#49017
Conversation
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68779903 |
rubennorte
force-pushed
the
export-D68779903
branch
from
400031e to
894d1cf
Compare
rubennorte
force-pushed
the
export-D68779903
branch
from
894d1cf to
b625aee
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68779903 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D68779903 |
rubennorte
force-pushed
the
export-D68779903
branch
from
b625aee to
97b9c95
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68779903 |
rubennorte
force-pushed
the
export-D68779903
branch
from
97b9c95 to
b3cab7e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68779903 |
rubennorte
force-pushed
the
export-D68779903
branch
from
b3cab7e to
ee3e27d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68779903 |
rubennorte
force-pushed
the
export-D68779903
branch
from
ee3e27d to
e79cd76
Compare
rubennorte
force-pushed
the
export-D68779903
branch
from
e79cd76 to
d5c1c68
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68779903 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D68779903 |
rubennorte
force-pushed
the
export-D68779903
branch
from
d5c1c68 to
aafe703
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68779903 |
rubennorte
force-pushed
the
export-D68779903
branch
from
aafe703 to
a9fda6b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68779903 |
rubennorte
force-pushed
the
export-D68779903
branch
from
a9fda6b to
053d9e9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68779903 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D68779903 |
rubennorte
force-pushed
the
export-D68779903
branch
from
053d9e9 to
9369ad1
Compare
rubennorte
force-pushed
the
export-D68779903
branch
from
9369ad1 to
2a341d3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68779903 |
rubennorte
force-pushed
the
export-D68779903
branch
from
2a341d3 to
bd89091
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68779903 |
Summary: Changelog: [internal] This name better reflects the fact that we're emptying the buffer when calling it. Reviewed By: javache Differential Revision: D67549202
Summary: Changelog: [internal] This replaces the existing string-based logs with something more structured, and increases the coverage to properly log all operations. As part of this work I had to refactor how we record mutations so they would be done while applying the mutations, and not before/after where necessary metadata might not be available yet/anymore. Reviewed By: sammy-SC Differential Revision: D67549201
Summary: Changelog: [internal] The debug string for props doesn't log `nativeID` so we can't access it in Fantom. This fixes that to simply future tests. Reviewed By: javache Differential Revision: D68779903
rubennorte
force-pushed
the
export-D68779903
branch
from
bd89091 to
75aa89d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68779903 |
|
This pull request has been merged in bb24ad0. |
2 participants
Summary:
Changelog: [internal]
The debug string for props doesn't log
nativeIDso we can't access it in Fantom. This fixes that to simply future tests.Differential Revision: D68779903