Migrate files in Libraries/EventEmitter and Libraries/Image to use export syntax#49020
Closed
iwoplaza wants to merge 1 commit into
Closed
Migrate files in Libraries/EventEmitter and Libraries/Image to use export syntax#49020iwoplaza wants to merge 1 commit into
iwoplaza wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68780876 |
iwoplaza
force-pushed
the
export-D68780876
branch
from
de48ec0 to
d1203a1
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68780876 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68780876 |
iwoplaza
force-pushed
the
export-D68780876
branch
from
d1203a1 to
b493ba2
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68780876 |
iwoplaza
force-pushed
the
export-D68780876
branch
from
b493ba2 to
801efcd
Compare
…port syntax (facebook#49020) Summary: ## Motivation Modernising the RN codebase to allow for modern Flow tooling to process it. ## This diff - Migrates the `Libraries/EventEmitter/*.js` and `Libraries/Image/*.js` files to use the `export` syntax. - Updates deep-imports of these files to use `.default` - Updates the current iteration of API snapshots (intended). Changelog: [General][Breaking] - Deep imports to modules inside `Libraries/EventEmitter` and `Libraries/Image/*.js` with `require` syntax need to be appended with '.default'. Reviewed By: huntie Differential Revision: D68780876
iwoplaza
force-pushed
the
export-D68780876
branch
from
801efcd to
d2e7554
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68780876 |
Collaborator
|
This pull request was successfully merged by @iwoplaza in 8783196 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Motivation
Modernising the RN codebase to allow for modern Flow tooling to process it.
This diff
Libraries/EventEmitter/*.jsandLibraries/Image/*.jsfiles to use theexportsyntax..defaultChangelog:
[General][Breaking] - Deep imports to modules inside
Libraries/EventEmitterandLibraries/Image/*.jswithrequiresyntax need to be appended with '.default'.Differential Revision: D68780876