Delete RawProps assignment operators#49030
Closed
javache wants to merge 2 commits into
Closed
Conversation
Summary: This was never being compiled, because we didn't import the header that set `RN_DEBUG_STRING_CONVERTIBLE` Will look at enabling `-Wundef` to catch these. Changelog: [Internal] Differential Revision: D68797482
Summary: Overwriting another RawProps object via `operator=` is rarely what we want, and these objects should be considered immutable once constructed. This will catch issues such as D68633985 Changelog: [General][Changed] Removed `RawProps::operator=` Differential Revision: D68797484
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68797484 |
javache
added a commit
to javache/react-native
that referenced
this pull request
Jan 29, 2025
Summary: Overwriting another RawProps object via `operator=` is rarely what we want, and these objects should be considered immutable once constructed. This will catch issues such as D68633985 Changelog: [General][Changed] Removed `RawProps::operator=` Reviewed By: sammy-SC Differential Revision: D68797484
Collaborator
|
This pull request was successfully merged by @javache in e4d1cf8 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Overwriting another RawProps object via
operator=is rarely what we want, and these objects should be considered immutable once constructed.This will catch issues such as D68633985
Changelog: [General][Changed] Removed
RawProps::operator=Differential Revision: D68797484