Create lint rule preventing uses of CommonJS exports#49079
Closed
coado wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68951212 |
facebook-github-bot
added
fb-exported
p: Software Mansion
Summary: The rule disallows using CommonJS exports in react-native and assets/registry package. ## Changelog: [Internal] - Created a lint rule that prevents using CommonJS exports Reviewed By: huntie Differential Revision: D68951212
coado
force-pushed
the
export-D68951212
branch
from
5164e87 to
121d30a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68951212 |
Collaborator
|
This pull request was successfully merged by @coado in 5c21537 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The rule disallows using CommonJS exports in react-native and assets/registry package.
Changelog:
[Internal] - Created a lint rule that prevents using CommonJS exports
Differential Revision: D68951212