Remove internal XHRInterceptor API#49132
Closed
huntie wants to merge 2 commits into
Closed
Conversation
…book#49081) Summary: Follows D68780147. We are depending on this API in one internal E2E test. Rename as `__setInterceptor_DO_NOT_USE`. Changelog: [Internal] Reviewed By: rubennorte Differential Revision: D68953084
Summary: Follows D68780147 and D68953084. We're able to safely remove this API by relocating the implementation into the one dependent internal test call site. Changelog: [Internal] Reviewed By: rubennorte Differential Revision: D69049203
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69049203 |
Collaborator
|
This pull request was successfully merged by @huntie in 880fd92 When will my fix make it into a release? | How to file a pick request? |
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Feb 5, 2025
Summary: Reverts facebook#49132. Turns out this is still load bearing / hard to extract. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D69177405
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Follows D68780147 and D68953084. We're able to safely remove this API by relocating the implementation into the one dependent internal test call site.
Changelog: [Internal]
Reviewed By: rubennorte
Differential Revision: D69049203