Skip to content

Make ResponseUtil internal #49153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mateoguzmana wants to merge 1 commit into from
Closed

Make ResponseUtil internal #49153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions packages/react-native/ReactAndroid/api/ReactAndroid.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3372,18 +3372,6 @@ public class com/facebook/react/modules/network/ProgressResponseBody : okhttp3/R
public fun totalBytesRead ()J
}

public final class com/facebook/react/modules/network/ResponseUtil {
public static final field INSTANCE Lcom/facebook/react/modules/network/ResponseUtil;
public static final fun onDataReceived (Lcom/facebook/react/bridge/ReactApplicationContext;ILcom/facebook/react/bridge/WritableMap;)V
public static final fun onDataReceived (Lcom/facebook/react/bridge/ReactApplicationContext;ILjava/lang/String;)V
public static final fun onDataReceivedProgress (Lcom/facebook/react/bridge/ReactApplicationContext;IJJ)V
public static final fun onDataSend (Lcom/facebook/react/bridge/ReactApplicationContext;IJJ)V
public static final fun onIncrementalDataReceived (Lcom/facebook/react/bridge/ReactApplicationContext;ILjava/lang/String;JJ)V
public static final fun onRequestError (Lcom/facebook/react/bridge/ReactApplicationContext;ILjava/lang/String;Ljava/lang/Throwable;)V
public static final fun onRequestSuccess (Lcom/facebook/react/bridge/ReactApplicationContext;I)V
public static final fun onResponseReceived (Lcom/facebook/react/bridge/ReactApplicationContext;IILcom/facebook/react/bridge/WritableMap;Ljava/lang/String;)V
}

public class com/facebook/react/modules/network/TLSSocketFactory : javax/net/ssl/SSLSocketFactory {
public fun <init> ()V
public fun createSocket (Ljava/lang/String;I)Ljava/net/Socket;
Expand Down
18 changes: 9 additions & 9 deletions ...eact-native/ReactAndroid/src/main/java/com/facebook/react/modules/network/ResponseUtil.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ import com.facebook.react.bridge.WritableMap
import java.net.SocketTimeoutException

/** Util methods to send network responses to JS. */
public object ResponseUtil {
internal object ResponseUtil {
@JvmStatic
public fun onDataSend(
fun onDataSend(
reactContext: ReactApplicationContext?,
requestId: Int,
progress: Long,
Expand All @@ -32,7 +32,7 @@ public object ResponseUtil {
}

@JvmStatic
public fun onIncrementalDataReceived(
fun onIncrementalDataReceived(
reactContext: ReactApplicationContext?,
requestId: Int,
data: String?,
Expand All @@ -51,7 +51,7 @@ public object ResponseUtil {
}

@JvmStatic
public fun onDataReceivedProgress(
fun onDataReceivedProgress(
reactContext: ReactApplicationContext?,
requestId: Int,
progress: Long,
Expand All @@ -68,7 +68,7 @@ public object ResponseUtil {
}

@JvmStatic
public fun onDataReceived(reactContext: ReactApplicationContext?, requestId: Int, data: String?) {
fun onDataReceived(reactContext: ReactApplicationContext?, requestId: Int, data: String?) {
val args =
Arguments.createArray().apply {
pushInt(requestId)
Expand All @@ -79,7 +79,7 @@ public object ResponseUtil {
}

@JvmStatic
public fun onDataReceived(
fun onDataReceived(
reactContext: ReactApplicationContext?,
requestId: Int,
data: WritableMap?
Expand All @@ -94,7 +94,7 @@ public object ResponseUtil {
}

@JvmStatic
public fun onRequestError(
fun onRequestError(
reactContext: ReactApplicationContext?,
requestId: Int,
error: String?,
Expand All @@ -114,7 +114,7 @@ public object ResponseUtil {
}

@JvmStatic
public fun onRequestSuccess(reactContext: ReactApplicationContext?, requestId: Int) {
fun onRequestSuccess(reactContext: ReactApplicationContext?, requestId: Int) {
val args =
Arguments.createArray().apply {
pushInt(requestId)
Expand All @@ -125,7 +125,7 @@ public object ResponseUtil {
}

@JvmStatic
public fun onResponseReceived(
fun onResponseReceived(
reactContext: ReactApplicationContext?,
requestId: Int,
statusCode: Int,
Expand Down