feat(ios): encapsulate device info listeners#49162
Closed
okwasniewski wants to merge 4 commits into
Closed
Conversation
facebook-github-bot
added
CLA Signed
okwasniewski
force-pushed
the
feat/encapsulate-deviceinfo
branch
from
48cb626 to
227a2c7
Compare
facebook-github-bot
added
the
Shared with Meta
cipolleschi
reviewed
Feb 4, 2025
Co-authored-by: Riccardo Cipolleschi <riccardo.cipolleschi@gmail.com>
okwasniewski
commented
Feb 4, 2025
cipolleschi
approved these changes
Feb 4, 2025
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
Author
|
Hey @cipolleschi I've pushed additional commit with observer cleanup on invalidation. |
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@cipolleschi merged this pull request in 7dc85d0. |
Collaborator
|
This pull request was successfully merged by @okwasniewski in 7dc85d0 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR encapsulates device info listeners removing additional logic from RCTAppDelegate which is a prerequisite for #49078
Now we use KVO (Key Value Observation) to listen to window size changes making this module's logic encapsulated + allows to use it in brownfield scenarios.
To keep backward compatibility RCTDeviceInfo still emits
RCTWindowFrameDidChangeNotificationChangelog:
[IOS] [ADDED] - encapsulate device info listeners
Test Plan:
Check if window size change listener is fired