[RN][Releases] Automate the check for the Release on NPM#49164
Closed
cipolleschi wants to merge 1 commit intomainfrom
Closed
[RN][Releases] Automate the check for the Release on NPM#49164cipolleschi wants to merge 1 commit intomainfrom
cipolleschi wants to merge 1 commit intomainfrom
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cipolleschi
force-pushed
the
cipolleschi/automate-checn-release-on-npm
branch
from
6f7b6de to
1ad9ee1
Compare
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cipolleschi
force-pushed
the
cipolleschi/automate-checn-release-on-npm
branch
2 times, most recently
from
939717c to
9b19adc
Compare
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cipolleschi
force-pushed
the
cipolleschi/automate-checn-release-on-npm
branch
from
9b19adc to
afef98c
Compare
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cipolleschi
force-pushed
the
cipolleschi/automate-checn-release-on-npm
branch
from
afef98c to
05a9c02
Compare
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cipolleschi
force-pushed
the
cipolleschi/automate-checn-release-on-npm
branch
from
05a9c02 to
ac74d0c
Compare
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@cipolleschi merged this pull request in a52f551. |
Collaborator
|
This pull request was successfully merged by @cipolleschi in a52f551 When will my fix make it into a release? | How to file a pick request? |
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 10, 2025
Summary: These snuck in, presumably accidentally, via #49164. This interferes with running test suites with a debugger connected (e.g, when debugging Jest itself). (Aside: we should probably enable [`eslint/no-debugger`](https://eslint.org/docs/latest/rules/no-debugger) to catch these) Changelog: [Internal] Differential Revision: D69377992
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 10, 2025
Summary: Pull Request resolved: #49289 These snuck in, presumably accidentally, via #49164. This interferes with running test suites with a debugger connected (e.g, when debugging Jest itself). (Aside: we should probably enable [`eslint/no-debugger`](https://eslint.org/docs/latest/rules/no-debugger) to catch these) Changelog: [Internal] Reviewed By: hoxyq Differential Revision: D69377992 fbshipit-source-id: 5d51d18be76f9b01852b2e5b7297b95452f36d55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
One of the steps we perform when doing a release is to run
npm view react-nativeto verify that the release has been published and it is available with the right tag.As of today, we check this manually.
This change aims at automating this check so that we don't have to do it manually ourselves.
Changelog:
[Internal] - Releases: automate the npm view check
Test Plan:
Created a veriftyReleaseOnNPM-tests.js jest test to verify that the script works fine.