Skip to content

Make ReactYogaConfigProvider internal #49170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cortinico wants to merge 1 commit into from
Closed

Make ReactYogaConfigProvider internal #49170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions packages/react-native/ReactAndroid/api/ReactAndroid.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4718,11 +4718,6 @@ public class com/facebook/react/uimanager/ReactStylesDiffMap {
public fun toString ()Ljava/lang/String;
}

public final class com/facebook/react/uimanager/ReactYogaConfigProvider {
public static final field INSTANCE Lcom/facebook/react/uimanager/ReactYogaConfigProvider;
public static final fun get ()Lcom/facebook/yoga/YogaConfig;
}

public abstract interface class com/facebook/react/uimanager/ReactZIndexedViewGroup {
public abstract fun getZIndexMappedChildIndex (I)I
public abstract fun updateDrawingOrder ()V
Expand Down
2 changes: 1 addition & 1 deletion ...t-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ReactShadowNodeImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ public class ReactShadowNodeImpl implements ReactShadowNode<ReactShadowNodeImpl>
private static final YogaConfig sYogaConfig;

static {
sYogaConfig = ReactYogaConfigProvider.get();
sYogaConfig = ReactYogaConfigProvider.INSTANCE.getYogaConfig();
}

private int mReactTag;
Expand Down
17 changes: 6 additions & 11 deletions ...native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ReactYogaConfigProvider.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,18 +11,13 @@ import com.facebook.yoga.YogaConfig
import com.facebook.yoga.YogaConfigFactory
import com.facebook.yoga.YogaErrata

public object ReactYogaConfigProvider {
internal object ReactYogaConfigProvider {

private val yogaConfig: YogaConfig by
val yogaConfig: YogaConfig by
lazy(LazyThreadSafetyMode.NONE) {
val config = YogaConfigFactory.create()
config.setPointScaleFactor(0f)
config.setErrata(YogaErrata.ALL)
config
YogaConfigFactory.create().apply {
setPointScaleFactor(0f)
setErrata(YogaErrata.ALL)
}
}

@JvmStatic
public fun get(): YogaConfig {
return yogaConfig
}
}