Cleanup public modifiers inside LayoutDirectionUtil#49172
Closed
cortinico wants to merge 2 commits into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69120493 |
cortinico
force-pushed
the
export-D69120493
branch
from
332beb9 to
95be4e8
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69120493 |
cortinico
force-pushed
the
export-D69120493
branch
from
95be4e8 to
10e9297
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69120493 |
Summary: This makes the `WindowUtil` class internal. I've verified that there are no meaningful usages in OSS: https://github.com/search?type=code&q=NOT+is%3Afork+NOT+org%3Afacebook+NOT+repo%3Areact-native-tvos%2Freact-native-tvos+NOT+repo%3Anuagoz%2Freact-native+NOT+repo%3A2lambda123%2Freact-native+NOT+repo%3Abeanchips%2Ffacebookreactnative+NOT+repo%3AfabOnReact%2Freact-native-notes+NOT+user%3Ahuntie+com.facebook.react.views.view.WindowUtil Changelog: [Internal] [Changed] - Reviewed By: tdn120 Differential Revision: D69120492
Summary: Those public keywords are unnecessary, let's remove them. Changelog: [Internal] [Changed] - Reviewed By: NickGerleman Differential Revision: D69120493
cortinico
force-pushed
the
export-D69120493
branch
from
10e9297 to
71feb54
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69120493 |
Contributor
|
This pull request has been merged in bf4c887. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Those public keywords are unnecessary, let's remove them.
Changelog:
[Internal] [Changed] -
Differential Revision: D69120493