Flip SurfaceMountingManager null view state SoftException to not crash #49271
+6
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69125274 |
facebook#49271) Summary: This error is somewhat expected, so causing the red box error popup is a bit too disruptive. Flip it to a no-crash exception. Changelog: [Internal] Reviewed By: Abbondanzo Differential Revision: D69125274
tdn120
force-pushed
the
export-D69125274
branch
from
a850293 to
d0e0955
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69125274 |
Contributor
|
This pull request has been merged in 94b5d4b. |
joemun
pushed a commit
to discord/react-native
that referenced
this pull request
Jul 16, 2025
facebook#49271) Summary: Pull Request resolved: facebook#49271 This error is somewhat expected, so causing the red box error popup is a bit too disruptive. Flip it to a no-crash exception. Changelog: [Internal] Reviewed By: Abbondanzo Differential Revision: D69125274 fbshipit-source-id: 0dc7ac59ac8637bdabde25bd8886b1aebf175395
gabrieldonadel
pushed a commit
to gabrieldonadel/react-native
that referenced
this pull request
Aug 12, 2025
facebook#49271) Summary: Pull Request resolved: facebook#49271 This error is somewhat expected, so causing the red box error popup is a bit too disruptive. Flip it to a no-crash exception. Changelog: [Internal] Reviewed By: Abbondanzo Differential Revision: D69125274 fbshipit-source-id: 0dc7ac59ac8637bdabde25bd8886b1aebf175395
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This error is somewhat expected, so causing the red box error popup is a bit too disruptive. Flip it to a no-crash exception.
Changelog: [Internal]
Reviewed By: Abbondanzo
Differential Revision: D69125274