Skip to content

Remove CountingOutputStream#49275

Closed
tdn120 wants to merge 1 commit into
facebook:mainfrom
tdn120:export-D69323277
Closed

Remove CountingOutputStream#49275
tdn120 wants to merge 1 commit into
facebook:mainfrom
tdn120:export-D69323277

Conversation

@tdn120
Copy link
Copy Markdown

@tdn120 tdn120 commented Feb 7, 2025

Summary:
This is a copied guava class and is only used in one spot. Remove it and just count directly in ProgressRequestBody.

Changelog: [Android][Removed] Remove CountingOutputStream

Differential Revision: D69323277

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 7, 2025
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D69323277

Summary:

This is a copied guava class and is only used in one spot.  Remove it and just count directly in ProgressRequestBody.

Changelog: [Android][Removed] Remove CountingOutputStream

Differential Revision: D69323277
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D69323277

@facebook-github-bot
Copy link
Copy Markdown
Contributor

Hi @tdn120!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Feb 12, 2025
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request has been merged in 403719c.

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @javache in 403719c

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants