decouple jsc when USE_THIRD_PARTY_JSC=1 on ios#49371
Closed
Kudo wants to merge 3 commits into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Kudo
force-pushed
the
@kudo/poc/decouple-jsc-ios
branch
from
4f00ef7 to
ce34e0f
Compare
Kudo
changed the title
facebook-github-bot
added
the
Shared with Meta
cipolleschi
approved these changes
Feb 14, 2025
Contributor
cipolleschi
left a comment
cipolleschi
left a comment
There was a problem hiding this comment.
It makes sense to me. I left a couple of minor suggestion to avoid code duplication.
| if ENV['USE_THIRD_PARTY_JSC'] != '1' | ||
| pod 'React-jsc', :path => "#{react_native_path}/ReactCommon/jsc" | ||
| if fabric_enabled | ||
| pod 'React-jsc/Fabric', :path => "#{react_native_path}/ReactCommon/jsc" |
Contributor
There was a problem hiding this comment.
not even sure that this subspec is actually needed...
Contributor
Author
There was a problem hiding this comment.
maybe not but that feels out of scope toward this pr. maybe we can update that in a separate pr?
Contributor
There was a problem hiding this comment.
I can create a separate one with removal
--------- Co-authored-by: Riccardo Cipolleschi <cipolleschi@meta.com>
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@cipolleschi merged this pull request in 176bed7. |
Collaborator
|
This pull request was successfully merged by @Kudo in 176bed7 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
an effort of lean core for jsc: https://github.com/Kudo/discussions-and-proposals/blob/%40kudo/lean-core-jsc/proposals/0836-lean-core-jsc.md. this pr tries to decouple all jsc code when
USE_THIRD_PARTY_JSC=1on iosthis pr includes these changes:
React-jscpod and pod dependency whenUSE_THIRD_PARTY_JSC=1JSCExecutorFactory/RCTJscInstancereferences whenUSE_THIRD_PARTY_JSC=1. it throws c++ errors likeNo JSRuntimeFactory specified.when no engine is specified (USE_HERMES=0 && USE_THIRD_PARTY_JSC=1). people need to override delegate methods to specify a JSRuntimeFactory.Changelog:
[IOS] [CHANGED] - Decouple JSC when
USE_THIRD_PARTY_JSC=1Test Plan:
RCT_NEW_ARCH_ENABLED=1 USE_THIRD_PARTY_JSC=1 USE_HERMES=0 USE_FRAMEWORKS=dynamic bundle exec pod installRCT_NEW_ARCH_ENABLED=0 USE_THIRD_PARTY_JSC=1 USE_HERMES=0 USE_FRAMEWORKS=dynamic bundle exec pod installRCT_NEW_ARCH_ENABLED=0 USE_THIRD_PARTY_JSC=1 USE_HERMES=0 bundle exec pod install