Kotlinify ReactZIndexedViewGroup & ReactOverflowViewWithInset#49384
Closed
mateoguzmana wants to merge 2 commits into
Closed
Kotlinify ReactZIndexedViewGroup & ReactOverflowViewWithInset#49384mateoguzmana wants to merge 2 commits into
ReactZIndexedViewGroup & ReactOverflowViewWithInset#49384mateoguzmana wants to merge 2 commits into
Conversation
facebook-github-bot
added
CLA Signed
mateoguzmana
force-pushed
the
refactor/kotlinify-react-uimanager-interfaces-
branch
from
6346842 to
39ee402
Compare
mateoguzmana
changed the title
ReactZIndexedViewGroup, ReactOverflowViewWithInset & ReactClippingViewGroupReactZIndexedViewGroup & ReactOverflowViewWithInset
cortinico
reviewed
Feb 13, 2025
Contributor
cortinico
left a comment
cortinico
left a comment
There was a problem hiding this comment.
Generally looks good but this could be breaking
cortinico
approved these changes
Feb 13, 2025
Contributor
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@cortinico merged this pull request in deafa72. |
Collaborator
|
This pull request was successfully merged by @mateoguzmana in deafa72 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Kotlinify 2 of the com.facebook.react.uimanager interfaces.
Changelog:
[INTERNAL] - Kotlinify ReactZIndexedViewGroup & ReactOverflowViewWithInset
Test Plan: