fix Modal crash when calling syncSystemBarsVisibility()#49386
Closed
alanleedev wants to merge 1 commit into
Closed
fix Modal crash when calling syncSystemBarsVisibility()#49386alanleedev wants to merge 1 commit into
alanleedev wants to merge 1 commit into
Conversation
Summary: It appears that `currentActivity.decorView` sometime is not attached to a window during the process of creating a Dialog for currently unknown reasons causing a crash. Add check to skip call to `syncSystemBarsVisibility()` in such case as current code cannot function without valid RootWindowInsets. Changelog: [Android][Fixed] - fixed crash with Modal when trying to call syncSystemBarsVisibility() Differential Revision: D69578581
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69578581 |
Contributor
|
This pull request has been merged in 141fb23. |
Collaborator
|
This pull request was successfully merged by @alanleedev in 141fb23 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
It appears that
currentActivity.decorViewsometime is not attached to a window during the process of creating a Dialog for currently unknown reasons causing a crash.Add check to skip call to
syncSystemBarsVisibility()in such case as current code cannot function without valid RootWindowInsets.Changelog:
[Android][Fixed] - fixed crash with Modal when trying to call syncSystemBarsVisibility()
Differential Revision: D69578581