RNGP - Do not access .project inside BuildCodegenCLITask#49398
Closed
cortinico wants to merge 1 commit into
Closed
RNGP - Do not access .project inside BuildCodegenCLITask#49398cortinico wants to merge 1 commit into
cortinico wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69592465 |
…acebook#49398) Summary: We should not invoke anything on the `project` property inside thet task. That will break Gradle Configuration Caching which is becoming the default in the next version of Gradle. This fixes it for the `BuildCodegenCLITask` task. Changelog: [Internal] [Changed] - Differential Revision: D69592465
cortinico
force-pushed
the
export-D69592465
branch
from
9f6cb78 to
66643e8
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69592465 |
Contributor
|
This pull request has been merged in 0dd9017. |
Collaborator
|
This pull request was successfully merged by @cortinico in 0dd9017 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
We should not invoke anything on the
projectproperty inside thet task.That will break Gradle Configuration Caching which is becoming the default in the next version of Gradle.
This fixes it for the
BuildCodegenCLITasktask.Changelog:
[Internal] [Changed] -
Differential Revision: D69592465