Migrate Utilities/dismissKeyboard.js, Utilities/GlobalPerformanceLogger.js & Utilities/SceneTracker.js to use export syntax#49402
Closed
iwoplaza wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69599636 |
…er.js & Utilities/SceneTracker.js to use export syntax (facebook#49402) Summary: ## Motivation Modernising the RN codebase to allow for modern Flow tooling to process it. ## This diff - Migrates `Utilities/dismissKeyboard.js`, `Utilities/GlobalPerformanceLogger.js` and `Utilities/SceneTracker.js` to use the export syntax. - Updates deep-imports of these files to use `.default` - Updates jest mocks - Updates the current iteration of API snapshots (intended). Changelog: [General][Breaking] - Deep imports to `Utilities/dismissKeyboard.js`, `Utilities/GlobalPerformanceLogger.js` or `Utilities/SceneTracker.js` with `require` syntax need to be appended with '.default'. Differential Revision: D69599636
iwoplaza
force-pushed
the
export-D69599636
branch
from
32951d0 to
166846e
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69599636 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69599636 |
Contributor
|
This pull request has been merged in fc6ca26. |
Collaborator
|
This pull request was successfully merged by @iwoplaza in fc6ca26 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Motivation
Modernising the RN codebase to allow for modern Flow tooling to process it.
This diff
Utilities/dismissKeyboard.js,Utilities/GlobalPerformanceLogger.jsandUtilities/SceneTracker.jsto use the export syntax..defaultChangelog:
[General][Breaking] - Deep imports to
Utilities/dismissKeyboard.js,Utilities/GlobalPerformanceLogger.jsorUtilities/SceneTracker.jswithrequiresyntax need to be appended with '.default'.Differential Revision: D69599636