Skip to content

Enforce that ViewManagers using codegen override getDelegate() method #49414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mdvacca wants to merge 1 commit into from
Closed

Enforce that ViewManagers using codegen override getDelegate() method #49414

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion ...ges/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ViewManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@
import com.facebook.react.bridge.BaseJavaModule;
import com.facebook.react.bridge.ReactApplicationContext;
import com.facebook.react.bridge.ReactContext;
import com.facebook.react.bridge.ReactNoCrashSoftException;
import com.facebook.react.bridge.ReactSoftExceptionLogger;
import com.facebook.react.bridge.ReadableArray;
import com.facebook.react.bridge.ReadableMap;
import com.facebook.react.common.annotations.UnstableReactNativeAPI;
Expand Down Expand Up @@ -113,7 +115,15 @@ public void updateProperties(@NonNull T viewToUpdate, ReactStylesDiffMap props)
* view manager should be set via this delegate
*/
protected ViewManagerDelegate<T> getDelegate() {
return new ViewManagerPropertyUpdater.GenericViewManagerDelegate(this);
if (this instanceof ViewManagerWithGeneratedInterface) {
ReactSoftExceptionLogger.logSoftException(
NAME,
new ReactNoCrashSoftException(
"ViewManager using codegen must override getDelegate method (name: "
+ getName()
+ ")."));
}
return new ViewManagerPropertyUpdater.GenericViewManagerDelegate<>(this);
}

private ViewManagerDelegate<T> getOrCreateViewManagerDelegate() {
Expand Down