Add missing break; in RCTEventDispatcher.mm#49416
Closed
christophpurrer wants to merge 1 commit into
Closed
Conversation
Summary:
[Changelog] [Internal] - Add missing break; in RCTEventDispatcher.mm
This fixes a compile error if a stricter warning setting is used as otherwise compilation fails with
```
react-native-github/packages/react-native/React/CoreModules/RCTEventDispatcher.mm:110:9: error: unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough]
110 | default:
| ^
react-native-github/packages/react-native/React/CoreModules/RCTEventDispatcher.mm:110:9: note: insert 'break;' to avoid fall-through
110 | default:
| ^
| break;
1 error generated.
Interaction with installer failed.
```
Reviewed By: joevilches
Differential Revision: D69625062
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69625062 |
Contributor
|
This pull request has been merged in 629c289. |
Collaborator
|
This pull request was successfully merged by @christophpurrer in 629c289 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
[Changelog] [Internal] - Add missing break; in RCTEventDispatcher.mm
This fixes a compile error if a stricter warning setting is used as otherwise compilation fails with
Reviewed By: joevilches
Differential Revision: D69625062