Setup Package.swift to consume the binaries#49435
Closed
cipolleschi wants to merge 3 commits into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69660943 |
cipolleschi
force-pushed
the
export-D69660943
branch
from
b05befb to
ba88e70
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69660943 |
Summary: This change adds the logic to copy the Headers files from the dependency folder to the generated frameworks folder. There is a slight possibility that this function will be implemented by the Swift PM build system, as I open [this question](https://forums.swift.org/t/xcodebuild-does-not-generate-headers-if-the-source-is-swift-pm/77856) on the Swift forums. In that case, we would be able to drop this. ## Changelog: [Internal] - Add function to copy headers over to the .frameworks Reviewed By: cortinico Differential Revision: D69656046
Summary: This change adds a function to create the xcframework sarting from the various .framework's slice built before. ## Changelog: [Internal] - Add function to create the xcframework Differential Revision: D69660662
Summary: This change adds a Package.swift file that allows to consume the binary from a local path. As soon as we publish this on Maven, we will update the path to the url. ## Changelog: [Internal] - Add the Package.swift file to consume the binary Reviewed By: cortinico Differential Revision: D69660943
cipolleschi
force-pushed
the
export-D69660943
branch
from
ba88e70 to
39dc7f6
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69660943 |
Contributor
|
This pull request has been merged in 11e53c0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This change adds a Package.swift file that allows to consume the binary from a local path.
As soon as we publish this on Maven, we will update the path to the url.
Changelog:
[Internal] - Add the Package.swift file to consume the binary
Differential Revision: D69660943
Test Plan
Tested in a sample app.
Just created a Sample App from Xcode, and renamed the ViewController. m --> ViewController.mm
Then I added the package dependency through the
Package Dependenciestab in XcodeI modified Target's header search path to point to:
After this step, it works flawlessly: