Skip to content

add event on debugger heartbeat and timeout#49437

Closed
vzaidman wants to merge 1 commit into
facebook:mainfrom
vzaidman:export-D69603217
Closed

add event on debugger heartbeat and timeout#49437
vzaidman wants to merge 1 commit into
facebook:mainfrom
vzaidman:export-D69603217

Conversation

@vzaidman
Copy link
Copy Markdown
Contributor

Summary:

  • Log every heartbeat with the same sampling as CDP commands (debugger_heartbeat)
  • Log abandoned connections due to heartbeat timeout (debugger_timeout)

Changelog:
[General][Added] - add inspector proxy events for debugger heartbeat (sampled) and abandoned connections

Reviewed By: robhogan

Differential Revision: D69603217

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Feb 14, 2025
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D69603217

)

Summary:

* Log every heartbeat with the same sampling as CDP commands (`debugger_heartbeat`)
* Log abandoned connections due to heartbeat timeout (`debugger_timeout`)

Changelog:
[General][Added] - add inspector proxy events for debugger heartbeat (sampled) and abandoned connections

Reviewed By: robhogan

Differential Revision: D69603217
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D69603217

@vzaidman vzaidman changed the title add scuba events on every heartbeat pong and termination [cdp] add event on inspector proxy heartbeat pong and timeout Feb 14, 2025
@vzaidman vzaidman changed the title [cdp] add event on inspector proxy heartbeat pong and timeout add event on inspector proxy heartbeat pong and timeout Feb 14, 2025
@vzaidman vzaidman changed the title add event on inspector proxy heartbeat pong and timeout add event on inspector proxy heartbeat and timeout Feb 14, 2025
@vzaidman vzaidman changed the title add event on inspector proxy heartbeat and timeout add event on debugger heartbeat and timeout Feb 14, 2025
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Feb 14, 2025
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request has been merged in 84f3cf9.

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @vzaidman in 84f3cf9

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants