Gradle Configuration Cache - Round 3#49439
Closed
cortinico wants to merge 3 commits into
Closed
Conversation
Summary: This is a first part of a series of diff needed to enable G. Configuration Cache: https://docs.gradle.org/current/userguide/configuration_cache.html as it will make our CI faster (and will be the default in the future Gradle version). Here I'm making all those tasks `prepare*` CC friendly. Those tasks were not CC friendly as they were referencing an external variable inside their body. We don't need to know the library version, we can just substring after the first folder and the tasks will behave as before. Changelog: [Internal] [Changed] - Differential Revision: D69655168
Summary: This is the second part of a series of diff needed to enable G. Configuration Cache: https://docs.gradle.org/current/userguide/configuration_cache.html as it will make our CI faster (and will be the default in the future Gradle version). Here I'm making the exec tasks CC friendly. The problem is that previously we were using explicit streams which are not CC friendly for stderr/stdout. The solution is to create a custom task and handle files as input properties. Changelog: [Internal] [Changed] - Differential Revision: D69662246
Summary: This is the next part of a series of diff needed to enable G. Configuration Cache: https://docs.gradle.org/current/userguide/configuration_cache.html as it will make our CI faster (and will be the default in the future Gradle version). Here I'm removing the `onlyIf` lambdas to make some tasks CC friendly. The problem is that some `onlyIf` lambdas can't easily be serialized. Here I'm cleaning up the problematic one to move the condition checks at execution time Changelog: [Internal] [Changed] - Differential Revision: D69664732
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69664732 |
Contributor
|
This pull request has been merged in 43cffb9. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This is the next part of a series of diff needed to enable G. Configuration Cache:
https://docs.gradle.org/current/userguide/configuration_cache.html
as it will make our CI faster (and will be the default in the future Gradle version).
Here I'm removing the
onlyIflambdas to make some tasks CC friendly.The problem is that some
onlyIflambdas can't easily be serialized. Here I'm cleaning upthe problematic one to move the condition checks at execution time
Changelog:
[Internal] [Changed] -
Differential Revision: D69664732