keep heartbeat between inspector proxy and debugger going even if not idle#49441
Closed
vzaidman wants to merge 1 commit into
Closed
keep heartbeat between inspector proxy and debugger going even if not idle#49441vzaidman wants to merge 1 commit into
vzaidman wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69665738 |
vzaidman
force-pushed
the
export-D69665738
branch
from
8d0902d to
53affca
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69665738 |
… idle (facebook#49441) Summary: Changelog: [General][Internal] - keep heartbeat between inspector proxy and debugger going even if not idle When heartbeat was only used to keep the connection alive and to detect debugger timeouts, it was enough to send a ping every time the connection was idle for 10 seconds. Now, when we use the heartbeat as a way to track how good is the round trip time between the inspector proxy and the debugger, we would like to make this tracking more reliable by sending a ping 10 seconds after each pong, even if the connection is not idle. It also simplifies the code and makes it more clear by removing the confusing `shouldSetTerminateTimeout` variable. Differential Revision: D69665738
vzaidman
force-pushed
the
export-D69665738
branch
from
53affca to
087281a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69665738 |
Contributor
|
This pull request has been merged in 5020333. |
Collaborator
|
This pull request was successfully merged by @vzaidman in 5020333 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[General][Internal] - keep heartbeat between inspector proxy and debugger going even if not idle
When heartbeat was only used to keep the connection alive and to detect debugger timeouts, it was enough to send a ping every time the connection was idle for 10 seconds.
Now, when we use the heartbeat as a way to track how good is the round trip time between the inspector proxy and the debugger, we would like to make this measurement is more reliable by sending a ping 10 seconds after each pong, even if the connection is not idle.
It also simplifies the code and makes it more clear by removing the confusing
shouldSetTerminateTimeoutvariable.Differential Revision: D69665738