Skip to content

Make ReactOverflowViewWithInset & NativeKind internal #49456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mateoguzmana wants to merge 2 commits into from
Closed

Make ReactOverflowViewWithInset & NativeKind internal #49456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1c63d9
Make ReactOverflowViewWithInset & NativeKind internal
mateoguzmana Feb 16, 2025
45c336c
Update ReactAndroid.api
mateoguzmana Feb 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions packages/react-native/ReactAndroid/api/ReactAndroid.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4065,15 +4065,6 @@ public final class com/facebook/react/uimanager/MeasureSpecAssertions {
public static final fun assertExplicitMeasureSpec (II)V
}

public final class com/facebook/react/uimanager/NativeKind : java/lang/Enum {
public static final field LEAF Lcom/facebook/react/uimanager/NativeKind;
public static final field NONE Lcom/facebook/react/uimanager/NativeKind;
public static final field PARENT Lcom/facebook/react/uimanager/NativeKind;
public static fun getEntries ()Lkotlin/enums/EnumEntries;
public static fun valueOf (Ljava/lang/String;)Lcom/facebook/react/uimanager/NativeKind;
public static fun values ()[Lcom/facebook/react/uimanager/NativeKind;
}

public class com/facebook/react/uimanager/NativeViewHierarchyManager {
public fun <init> (Lcom/facebook/react/uimanager/ViewManagerRegistry;)V
public fun <init> (Lcom/facebook/react/uimanager/ViewManagerRegistry;Lcom/facebook/react/uimanager/RootViewManager;)V
Expand Down Expand Up @@ -4351,11 +4342,6 @@ public abstract interface class com/facebook/react/uimanager/ReactOverflowView {
public abstract fun getOverflow ()Ljava/lang/String;
}

public abstract interface class com/facebook/react/uimanager/ReactOverflowViewWithInset : com/facebook/react/uimanager/ReactOverflowView {
public abstract fun getOverflowInset ()Landroid/graphics/Rect;
public abstract fun setOverflowInset (IIII)V
}

public abstract interface class com/facebook/react/uimanager/ReactPointerEventsView {
public abstract fun getPointerEvents ()Lcom/facebook/react/uimanager/PointerEvents;
}
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/NativeKind.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ package com.facebook.react.uimanager
// - `kind == PARENT` checks whether the node can host children in the native tree.
// - `kind != NONE` checks whether the node appears in the native tree.

public enum class NativeKind {
internal enum class NativeKind {
// Node is in the native hierarchy and the HierarchyOptimizer should assume it can host children
// (e.g. because it's a ViewGroup). Note that it's okay if the node doesn't support children. When
// the HierarchyOptimizer generates children manipulation commands for that node, the
Expand Down
6 changes: 3 additions & 3 deletions ...ive/ReactAndroid/src/main/java/com/facebook/react/uimanager/ReactOverflowViewWithInset.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,19 +15,19 @@ import android.view.View
* to use the overflowInset values. This allows the overflow information to be used by
* [TouchTargetHelper] to determine if a View is touchable.
*/
public interface ReactOverflowViewWithInset : ReactOverflowView {
internal interface ReactOverflowViewWithInset : ReactOverflowView {
/**
* Get the overflow inset rect values which indicate the extensions to the boundaries of current
* view that wraps all of its children views
*
* @return Rect of integers indicating the left, top, right, bottom pixel extensions. The values
* are non-positive (indicating enlarged boundaries).
*/
public val overflowInset: Rect
val overflowInset: Rect

/**
* Set the overflow inset rect values which indicate the extensions to the boundaries of current
* view that wraps all of its children views
*/
public fun setOverflowInset(left: Int, top: Int, right: Int, bottom: Int)
fun setOverflowInset(left: Int, top: Int, right: Int, bottom: Int)
}