Remove com.facebook.react.modules.network.TLSSocketFactory class#49457
Closed
mateoguzmana wants to merge 1 commit into
Closed
Remove com.facebook.react.modules.network.TLSSocketFactory class#49457mateoguzmana wants to merge 1 commit into
com.facebook.react.modules.network.TLSSocketFactory class#49457mateoguzmana wants to merge 1 commit into
Conversation
facebook-github-bot
added
the
CLA Signed
facebook-github-bot
added
the
Shared with Meta
Contributor
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@cortinico merged this pull request in e065411. |
Collaborator
|
This pull request was successfully merged by @mateoguzmana in e065411 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
As part of the initiative to reduce the public API surface, I found that this class is not used in the codebase and can be removed.
GH search for TLSSocketFactory – this class has some OSS usages, but all the ones I found are from old/non-active repos so that's why I think it is safe to remove but should be marked as [BREAKING] at the same time.
Changelog:
[ANDROID] [BREAKING] - Remove com.facebook.react.modules.network.TLSSocketFactory class
Test Plan: