remove use of RCTUnsafeExecuteOnMainQueueSync and main thread setup from RCTDeviceInfo#49478
Closed
sammy-SC wants to merge 2 commits into
Closed
remove use of RCTUnsafeExecuteOnMainQueueSync and main thread setup from RCTDeviceInfo#49478sammy-SC wants to merge 2 commits into
sammy-SC wants to merge 2 commits into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69747829 |
sammy-SC
force-pushed
the
export-D69747829
branch
from
c45499e to
9fde0d0
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69747829 |
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
Feb 18, 2025
…ad setup from RCTDeviceInfo (facebook#49478) Summary: changelog: [internal] Move all main thread resources that RCTDeviceInfo needs to RCTKeyWindowValuesProxy class. That way, RCTDeviceInfo does not needs to use RCTUnsafeExecuteOnMainQueueSync and doesn't require main thread setup. Differential Revision: D69747829
…zation (facebook#49477) Summary: changelog: [internal] Move all main thread resources from RCTAccessibilityManager to a proxy object: RCTInitialAccessibilityValuesProxy Reviewed By: javache Differential Revision: D69747648
…rom RCTDeviceInfo (facebook#49478) Summary: changelog: [internal] Move all main thread resources that RCTDeviceInfo needs to RCTKeyWindowValuesProxy class. That way, RCTDeviceInfo does not needs to use RCTUnsafeExecuteOnMainQueueSync and doesn't require main thread setup. Reviewed By: javache Differential Revision: D69747829
sammy-SC
force-pushed
the
export-D69747829
branch
from
9fde0d0 to
00e4146
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69747829 |
Contributor
|
This pull request has been merged in 470bc40. |
Contributor
|
This pull request has been reverted by ca49b51. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
changelog: [internal]
Move all main thread resources that RCTDeviceInfo needs to RCTKeyWindowValuesProxy class. That way, RCTDeviceInfo does not needs to use RCTUnsafeExecuteOnMainQueueSync and doesn't require main thread setup.
Differential Revision: D69747829