Skip to content

Make DefaultDevSupportManagerFactory, InspectorFlags & JSDebuggerWebSocketClient internal #49506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mateoguzmana wants to merge 1 commit into from
Closed

Make DefaultDevSupportManagerFactory, InspectorFlags & JSDebuggerWebSocketClient internal #49506

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 0 additions & 25 deletions packages/react-native/ReactAndroid/api/ReactAndroid.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2049,12 +2049,6 @@ public final class com/facebook/react/devsupport/DefaultDevLoadingViewImplementa
public final fun setDevLoadingEnabled (Z)V
}

public final class com/facebook/react/devsupport/DefaultDevSupportManagerFactory : com/facebook/react/devsupport/DevSupportManagerFactory {
public fun <init> ()V
public fun create (Landroid/content/Context;Lcom/facebook/react/devsupport/ReactInstanceDevHelper;Ljava/lang/String;ZLcom/facebook/react/devsupport/interfaces/RedBoxHandler;Lcom/facebook/react/devsupport/interfaces/DevBundleDownloadListener;ILjava/util/Map;Lcom/facebook/react/common/SurfaceDelegateFactory;Lcom/facebook/react/devsupport/interfaces/DevLoadingViewManager;Lcom/facebook/react/devsupport/interfaces/PausedInDebuggerOverlayManager;)Lcom/facebook/react/devsupport/interfaces/DevSupportManager;
public fun create (Landroid/content/Context;Lcom/facebook/react/devsupport/ReactInstanceDevHelper;Ljava/lang/String;ZLcom/facebook/react/devsupport/interfaces/RedBoxHandler;Lcom/facebook/react/devsupport/interfaces/DevBundleDownloadListener;ILjava/util/Map;Lcom/facebook/react/common/SurfaceDelegateFactory;Lcom/facebook/react/devsupport/interfaces/DevLoadingViewManager;Lcom/facebook/react/devsupport/interfaces/PausedInDebuggerOverlayManager;Z)Lcom/facebook/react/devsupport/interfaces/DevSupportManager;
}

public class com/facebook/react/devsupport/DevServerHelper {
public fun <init> (Lcom/facebook/react/modules/debug/interfaces/DeveloperSettings;Landroid/content/Context;Lcom/facebook/react/packagerconnection/PackagerConnectionSettings;)V
public fun closeInspectorConnection ()V
Expand Down Expand Up @@ -2160,25 +2154,6 @@ public abstract interface class com/facebook/react/devsupport/HMRClient : com/fa
public abstract fun setup (Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;IZLjava/lang/String;)V
}

public final class com/facebook/react/devsupport/InspectorFlags {
public static final field INSTANCE Lcom/facebook/react/devsupport/InspectorFlags;
public static final fun getFuseboxEnabled ()Z
public static final fun getIsProfilingBuild ()Z
}

public class com/facebook/react/devsupport/JSDebuggerWebSocketClient : okhttp3/WebSocketListener {
public fun <init> ()V
public fun closeQuietly ()V
public fun connect (Ljava/lang/String;Lcom/facebook/react/devsupport/JSDebuggerWebSocketClient$JSDebuggerCallback;)V
public fun executeJSCall (Ljava/lang/String;Ljava/lang/String;Lcom/facebook/react/devsupport/JSDebuggerWebSocketClient$JSDebuggerCallback;)V
public fun loadBundle (Ljava/lang/String;Ljava/util/HashMap;Lcom/facebook/react/devsupport/JSDebuggerWebSocketClient$JSDebuggerCallback;)V
public fun onClosed (Lokhttp3/WebSocket;ILjava/lang/String;)V
public fun onFailure (Lokhttp3/WebSocket;Ljava/lang/Throwable;Lokhttp3/Response;)V
public fun onMessage (Lokhttp3/WebSocket;Ljava/lang/String;)V
public fun onOpen (Lokhttp3/WebSocket;Lokhttp3/Response;)V
public fun prepareJSRuntime (Lcom/facebook/react/devsupport/JSDebuggerWebSocketClient$JSDebuggerCallback;)V
}

public abstract interface class com/facebook/react/devsupport/JSDebuggerWebSocketClient$JSDebuggerCallback {
public abstract fun onFailure (Ljava/lang/Throwable;)V
public abstract fun onSuccess (Ljava/lang/String;)V
Expand Down
4 changes: 2 additions & 2 deletions ...actAndroid/src/main/java/com/facebook/react/devsupport/DefaultDevSupportManagerFactory.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@ import com.facebook.react.packagerconnection.RequestHandler
* dependencies in release builds. If the class isn't found, [PerftestDevSupportManager] is returned
* instead.
*/
public class DefaultDevSupportManagerFactory : DevSupportManagerFactory {
internal class DefaultDevSupportManagerFactory : DevSupportManagerFactory {

public override fun create(
override fun create(
applicationContext: Context,
reactInstanceManagerHelper: ReactInstanceDevHelper,
packagerPathForJSBundleName: String?,
Expand Down
6 changes: 3 additions & 3 deletions ...s/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/InspectorFlags.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,12 @@ import com.facebook.proguard.annotations.DoNotStrip

/** JNI wrapper for `jsinspector_modern::InspectorFlags`. */
@DoNotStrip
public object InspectorFlags {
internal object InspectorFlags {
init {
DevSupportSoLoader.staticInit()
}

@DoNotStrip @JvmStatic public external fun getFuseboxEnabled(): Boolean
@DoNotStrip @JvmStatic external fun getFuseboxEnabled(): Boolean

@DoNotStrip @JvmStatic public external fun getIsProfilingBuild(): Boolean
@DoNotStrip @JvmStatic external fun getIsProfilingBuild(): Boolean
}
2 changes: 1 addition & 1 deletion ...e/ReactAndroid/src/main/java/com/facebook/react/devsupport/JSDebuggerWebSocketClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
import okhttp3.WebSocketListener;

/** A wrapper around WebSocketClient that recognizes RN debugging message format. */
public class JSDebuggerWebSocketClient extends WebSocketListener {
class JSDebuggerWebSocketClient extends WebSocketListener {

private static final String TAG = "JSDebuggerWebSocketClient";

Expand Down