'[skip ci] [RN][Android] Sort kotlin modifier to canonical order#49533
Closed
cortinico wants to merge 1 commit into
Closed
'[skip ci] [RN][Android] Sort kotlin modifier to canonical order#49533cortinico wants to merge 1 commit into
cortinico wants to merge 1 commit into
Conversation
Summary: Android Studio is telling us that those modifiers are not sorted according to the '\''canonical order'\''. This is quite annoying while editing so I'\''m sorthing them all using the IDE inspection. We should add a rule inside ktfmt for this, but that'\''s another work. Changelog: [Internal] [Changed] - Differential Revision: D69857730
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69857730 |
Contributor
|
This pull request has been merged in fefa17a. |
Collaborator
|
This pull request was successfully merged by @cortinico in fefa17a When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Android Studio is telling us that those modifiers are not sorted according to the '''canonical order'''.
This is quite annoying while editing so I'''m sorthing them all using the IDE inspection.
We should add a rule inside ktfmt for this, but that'''s another work.
Changelog:
[Internal] [Changed] -
Differential Revision: D69857730