'[skip ci] [RN][Android] Use on all the remaining ReactAndroid targets#49744
Closed
cortinico wants to merge 2 commits into
Closed
'[skip ci] [RN][Android] Use on all the remaining ReactAndroid targets#49744cortinico wants to merge 2 commits into
cortinico wants to merge 2 commits into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70386747 |
cortinico
force-pushed
the
export-D70386747
branch
from
06d7fb1 to
127c7f9
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70386747 |
cortinico
force-pushed
the
export-D70386747
branch
from
127c7f9 to
d8e9af1
Compare
cortinico
force-pushed
the
export-D70386747
branch
from
d8e9af1 to
7cd9a97
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70386747 |
cortinico
force-pushed
the
export-D70386747
branch
from
7cd9a97 to
0186e3d
Compare
…facebook#49747) Summary: I'm adding the `target_compile_reactnative_options` to centralize the management of compilation flags for React Native CMake build. Changelog: [Internal] [Changed] - Reviewed By: javache Differential Revision: D70386746
…droid targets (facebook#49744) Summary: Those targets inside ReactAndroid were not setting the compiler flags correctly for React Native. This change fixes them. Changelog: [Internal] [Changed] - Reviewed By: javache Differential Revision: D70386747
cortinico
force-pushed
the
export-D70386747
branch
from
0186e3d to
4305c48
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70386747 |
Contributor
|
This pull request has been merged in 87466a2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Those targets inside ReactAndroid were not setting the compiler flags correctly for React Native.
This change fixes them.
Changelog:
[Internal] [Changed] -
Differential Revision: D70386747