Closed
Conversation
facebook-github-bot
added
the
CLA Signed
cipolleschi
force-pushed
the
export-D70493507
branch
from
19881b9 to
5b01cc5
Compare
Summary: The cache for RNTester is broken because the matrix parameters used to test RNTester are not part of the job_id that is used to create the cache keys to restore the Podfile.lock. This means that we have a race condition on which job of the matrix manages to save the cache. However, those caches are not always valid for the other jobs that presents different matrix parameters. This change should fix the issue. ## Changelog: [Internal] - Fix test-rn-tester cache Cache Reviewed By: cortinico Differential Revision: D70493507
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70493507 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70493507 |
cipolleschi
force-pushed
the
export-D70493507
branch
from
5b01cc5 to
3a68a11
Compare
Contributor
|
This pull request has been merged in 4205294. |
Collaborator
|
This pull request was successfully merged by @cipolleschi in 4205294 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The cache for RNTester is broken because the matrix parameters used to test RNTester are not part of the job_id that is used to create the cache keys to restore the Podfile.lock.
This means that we have a race condition on which job of the matrix manages to save the cache. However, those caches are not always valid for the other jobs that presents different matrix parameters.
This change should fix the issue.
Changelog:
[Internal] - Fix test-rn-tester cache Cache
Differential Revision: D70493507