Increase Hermes Sampling rate to 10kHz#49795
Closed
hoxyq wants to merge 2 commits into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70395983 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70395983 |
Summary: # Changelog: [Internal] Before, we would store all User Timings and Timeline Events in the PerformanceTracer's buffer, and then add Profile event to it as well. On larget apps, the amount of events buffered could reach ~100k, which inevitably would cause OOM. With this approach, we will flush out buffered events from PerformanceTracer first, then do JavaScript Profile serialization, then send it over CDP straight away. Differential Revision: D70395982
Summary: Pull Request resolved: facebook#49795 # Changelog: [Internal] I've been able to reliably and consistently record samples with an interval between 2 consecutive ones to be ~0.1-0.2ms, lets bump the sampling frequency to have more frames. On Windows, Hermes Sampler peaks at ~500Hz, so this won't have much effect. Reviewed By: huntie Differential Revision: D70395983
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70395983 |
Contributor
|
This pull request has been merged in ed7dbce. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
I've been able to reliably and consistently record samples with an interval between 2 consecutive ones to be ~0.1-0.2ms, lets bump the sampling frequency to have more frames.
On Windows, Hermes Sampler peaks at ~500Hz, so this won't have much effect.
Differential Revision: D70395983