Skip to content

Correctly propagate prepareToRecycleView return value #49858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
javache wants to merge 1 commit into from
Closed

Correctly propagate prepareToRecycleView return value #49858

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...native/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTextViewManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ public ReactTextViewManager(@Nullable ReactTextViewManagerCallback reactTextView
// Defaults from ReactTextAnchorViewManager
setSelectionColor(preparedView, null);
}
return view;
return preparedView;
}

@Override
Expand Down
4 changes: 2 additions & 2 deletions ...react-native/ReactAndroid/src/main/java/com/facebook/react/views/view/ReactViewManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,11 +72,11 @@ public open class ReactViewManager : ReactClippingViewManager<ReactViewGroup>()
override fun prepareToRecycleView(
reactContext: ThemedReactContext,
view: ReactViewGroup
): ReactViewGroup {
): ReactViewGroup? {
// BaseViewManager
val preparedView = super.prepareToRecycleView(reactContext, view)
preparedView?.recycleView()
return view
return preparedView
}

@ReactProp(name = "accessible")
Expand Down