add fantom test for view culling inside <Modal />#49860
Closed
sammy-SC wants to merge 3 commits into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70696834 |
sammy-SC
force-pushed
the
export-D70696834
branch
from
4075f9b to
c61c486
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70696834 |
sammy-SC
force-pushed
the
export-D70696834
branch
from
c61c486 to
7b60669
Compare
Differential Revision: D69883384
Differential Revision: D70696524
sammy-SC
force-pushed
the
export-D70696834
branch
from
7b60669 to
b659471
Compare
Summary: Pull Request resolved: facebook#49860 changelog: [internal] now that Fantom supports tests with <Modal />, add a test to cover scenario where <ScrollView /> is inside of <Modal />. Reviewed By: rubennorte, rshest Differential Revision: D70696834
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70696834 |
sammy-SC
force-pushed
the
export-D70696834
branch
from
b659471 to
ee6c215
Compare
Contributor
|
This pull request has been merged in eeef060. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
changelog: [internal]
now that Fantom supports tests with , add a test to cover scenario where is inside of .
Differential Revision: D70696834