marked acquireWakeLockNow as static as it was static before#49875
marked acquireWakeLockNow as static as it was static before#49875mstrokin wants to merge 3 commits into
Conversation
facebook-github-bot
added
CLA Signed
|
This looks right to me - was clearly static before: 9afad52#diff-a794349a87c640230f45e4ef37cc183713fc8dda05348e033027e6fde3a647eeL31 @cipolleschi this looks like the right direction for the API fix though I haven't tested it yet |
|
@cortinico can you take this? Changing the ReactAndroid.api won't fix the issue. that file is generated from the source code. |
|
Sorry, didn't notice it's a generated file, I've added @JvmStatic annotation so that Kotlin generates static function properly. |
|
Added fixed .api file (generated by binary-compatibility-validator) |
|
@javache has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @mstrokin in 2a58201 When will my fix make it into a release? | How to file a pick request? |
|
You guys are awesome - @mstrokin - 🏆 for fixing a problem before it's even a problem (nailing it while in RC phase...), @cipolleschi 🏆 for the focused suggestion to finalize it. Boom. Really appreciate it over in react-native-firebase land |
|
Just tried a build with 0.79.0-rc.2 and it failed, the fix here appears good but there does not appear to be a pick request for the 0.79 branch and I suppose this was merged post-branch cut |
Summary: acquireWakeLockNow was static before but wasn't marked as static in 9afad52 when changing code to Kotlin. This breaks react-native-firebase but I've submitted the bug report there as I guess it might be fixed there too. ## Changelog: [ANDROID] [FIXED] - Marked acquireWakeLockNow as static Pull Request resolved: #49875 Test Plan: No tests as it reverts the broken change Reviewed By: rshest Differential Revision: D70773675 Pulled By: javache fbshipit-source-id: d7363702dfec078b7e6d2693d05b8ab87e818522
|
This pull request was successfully merged by @mstrokin in 6699563 When will my fix make it into a release? | How to file a pick request? |
5 participants
Summary:
acquireWakeLockNow was static before but wasn't marked as static in 9afad52 when changing code to Kotlin.
This breaks react-native-firebase but I've submitted the bug report there as I guess it might be fixed there too.
Changelog:
[ANDROID] [FIXED] - Marked acquireWakeLockNow as static
Test plan:
No tests as it reverts the broken change